Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide stable Badger API #161

Closed
rohanthewiz opened this issue Aug 14, 2017 · 6 comments
Closed

Provide stable Badger API #161

rohanthewiz opened this issue Aug 14, 2017 · 6 comments
Assignees
Labels
kind/enhancement Something could be better.
Milestone

Comments

@rohanthewiz
Copy link

Is the API completely unstable? If not, then how about some tags to version lock to (semver.org).
Example git tag -a v0.1.1 -m "A usable release"

Thanks. I know it's a lot of work!

@manishrjain
Copy link
Contributor

Sure, we should be able to do that. I think we can cut a v1.0 release of Badger soon, because we've been fortifying it for a while -- particularly with testing crash resilience against ALICE (blog post upcoming), we should be good.

Expect this in a few weeks.

@rohanthewiz
Copy link
Author

rohanthewiz commented Aug 15, 2017 via email

@manishrjain
Copy link
Contributor

Created a milestone for v1.0 -- aimed at end of this month -- though might be mid of next month.

@manishrjain manishrjain added this to the v1.0 milestone Aug 18, 2017
@manishrjain manishrjain added the kind/enhancement Something could be better. label Aug 18, 2017
@manishrjain manishrjain self-assigned this Aug 18, 2017
@manishrjain manishrjain modified the milestone: v1.0 Sep 11, 2017
@manishrjain manishrjain changed the title Semantic Versioning? Provide stable Badger API Sep 14, 2017
@whyrusleeping
Copy link

Hey guys, any update here?

@manishrjain
Copy link
Contributor

manishrjain commented Oct 3, 2017

Hey @whyrusleeping, we've changed the APIs in a major way to introduce transactions to Badger (in develop branch). So, what we're going to do is to tag v0.8 as the current version of Dgraph, and when transactions land, they'd become master (and tagged as v0.9, this won't happen because of how gopkg.in works, we'll release txns directly as v1.0), leading up to v1.0.

This way, anyone on current APIs can continue to use them and switch whenever they're ready to.

@deepakjois
Copy link
Contributor

We did a review of the API yesterday, and removed some methods which did not really belong in the public API, and were not being used externally.

What we have now is what will go into v1.0, which should be out soon pending a couple of minor bug fixes. But the API itself should not undergo any further changes. Closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Something could be better.
Development

No branches or pull requests

4 participants