Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve max text length #6

Closed
3 tasks done
didix21 opened this issue May 5, 2018 · 7 comments · Fixed by #53
Closed
3 tasks done

Solve max text length #6

didix21 opened this issue May 5, 2018 · 7 comments · Fixed by #53
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@didix21
Copy link
Owner

didix21 commented May 5, 2018

  • Max 80 char on new_paragraph
  • Max 80 char on new_line
  • Max 80 char on write
@didix21 didix21 added the bug Something isn't working label May 5, 2018
@didix21
Copy link
Owner Author

didix21 commented May 5, 2018

When writing some long text on new_paragraph, new_line or write methods. The string is saved on file without jump lines.

@didix21
Copy link
Owner Author

didix21 commented May 5, 2018

This max length should be about 80 characters.

@didix21 didix21 added the help wanted Extra attention is needed label Sep 27, 2019
@mhmdkanj
Copy link

mhmdkanj commented Jun 3, 2021

Hi,

I could possibly work on that.
To be clear, new_paragraph, new_line and write take the text to be added as an argument. Did you mean to make the maximum str length of this added text to be 80 chars, or is it 80 chars per line written in the raw md file (so that we don't have very long lines)?

Best,
MK

@didix21
Copy link
Owner Author

didix21 commented Jun 3, 2021

Any help is welcome! Thanks!
I was meaning the second case. I was thinking must truncate text each 80 chars. Maybe, nowadays almost any pc screen have HD resolution. So, it can be set to 120 chars.

@didix21
Copy link
Owner Author

didix21 commented Jun 3, 2021

  • Max 120 char on new_paragraph
  • Max 120 char on new_line
  • Max 120 char on write

@mhmdkanj
Copy link

mhmdkanj commented Jun 6, 2021

@didix21 I just submitted a PR on this. Would like to see your input & many thanks in advance!

@didix21
Copy link
Owner Author

didix21 commented Jun 7, 2021

Thanks @mhmdkanj for your work! As soon as I can check it, I give you some feedback!

mhmdkanj pushed a commit to mhmdkanj/mdutils that referenced this issue Jun 7, 2021
didix21 added a commit that referenced this issue Jun 8, 2021
Fix #6: add option to wrap text on new lines, paragraphs and writes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants