-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite loop when splitting pages #2884
Comments
I think part of the problem may be here:
This doesn't take into account padding at the top of the page or fixed elements that will always appear before the node, so shouldBreak will return true even though the node is already as high up the page as it can go. |
Minimal example:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Some layouts loop when calling splitPage; all the nodes are transferred to the next page.
To Reproduce
Apologies for the layout, it's reverse engineered from a customer's PDF that showed the problem.
This snippet will hang the renderer
Expected behavior
ReactPDF.render() completes
Screenshots
N/A
Desktop (please complete the following information):
@react-pdf/renderer v4.0.0 on Node 20 (also hangs the REPL).
The text was updated successfully, but these errors were encountered: