fix: fetch assets in dynamic content (#1369, #1587, #1630, #1936, #2064) #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mskec
force-pushed
the
issue-2064/image-inside-dynamic-content
branch
from
15fa25e
to
5a967f1
Compare
mskec
force-pushed
the
issue-2064/image-inside-dynamic-content
branch
from
5a967f1
to
b1fce3b
Compare
|
Hi @jeetiss, what do you think about this PR? Do you want me to improve something? |
|
Approve ! |
|
Hi @jeetiss, @diegomura, it's been a couple of months since opening the PR without receiving any feedback. Can you please take a look at it? Please let me know if you have some concerns on how it's implemented and maybe we can find another solution. The PR is fixing a couple of issues that others have reported and they and me would love to have it merged. |
|
@mskec I have some issue font load by fs not working in render function |
|
@tigerza117 do you have problem when you use the branch from this PR or in general? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes crashes with images inside dynamic content.
From looking at it, the problem was that assets weren't loaded for images inside dynamic content because
resolveAssetswas executed beforeresolvePagination.To resolve this, I've added
resolveAssetsas a step in relayout which forced me to add a bunch of async/await all overresolvePagination.fixes: #1369, #1587, #1630, #1936, #2064