Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow src and href attributes to also be numbers #2835

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

karlwithak
Copy link

In the link annotation, we can see that numbers are accepted to allow linking directly to page numbers.

if (typeof url === 'number') {

This PR updates the type definitions of the src and href attribute on the Link component to allow passing in page numbers.

Copy link

changeset-bot bot commented Aug 1, 2024

⚠️ No Changeset found

Latest commit: ffbcc61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@karlwithak karlwithak changed the title Allow src and href attributes to also be numbers fix: Allow src and href attributes to also be numbers Aug 1, 2024
@diegomura
Copy link
Owner

You linked a pdfkit line, but that does not mean @react-pdf/renderer allows passing numbers as src or href. In which case we would want this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants