Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom authenticatedAttributes #991

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dettoni
Copy link

@dettoni dettoni commented Jul 13, 2022

Handling inside forge attributes like messageDigest and signingTime is
really nice, but not allowing any other attributes is quite limiting.

This change allow the user to build and use any attribute with ASN.1.

This problem have been addressed in #400 but no PR were open. I used the name asn1Value instead of rawValue because I think rawValue would be misleading.

An example of the need for this is in #768 where it is proposed a new attribute signingCertificateV2, but signingCertificateV2 can be way more complex than the version proposed. sigPolicyId is another example of attribute that would be quite hard to implement in a general form but is not hard to build for an specific policy.

Handling inside forge attributes like messageDigest and signingTime is
really nice, but not allowing any other attributes is quite limiting.

This change allow the user to build and use any attribute with ASN.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant