Cherry-pick fixes from v1.0.1 to release-0.4 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tag DO volumes on create/attach
* tag snapshots at creation
driver: don't check limits on worker nodes
Fix support for volume snapshots by setting snapshot id on volume creation.
This test failed more often than not in my local testing. Previously we only waited for the pod to be running which didn't guarantee the file had been created, nor that it had been sync'ed to the block device.
Goreportcard fixes
deploy: sync DO Kubernetes changes
- sembump (github.com/jessfraz/junk/sembump) is unsupported by the author and won't build on mac/windows. Make NEW_VERSION explicit.
jcodybaker
force-pushed
the
release-0.4-cp-1-0-1
branch
from
fdb4b55
to
5adab4f
Compare
|
Verified this passes both the DO CSI integration tests and Kubernetes Conformance E2E tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cherry-picks the following PRs from v1.0.1. Once merged, a separate PR will be created for the v0.4.1 release via
make bump-version. Lastly, a final PR will be created to update the master changelog to reflect what's in v0.4.1.--do-tagflag[GH-130]
[GH-129]
[GH-121]
node-driver-registrarto beconsistent with the other role bindings.
[GH-118]
--tokenflag for thecsi-do-nodedriver. Drivers running onthe node don't need the token anymore.
[GH-118]
to talk to DigitalOcean API)
[GH-142]
godo(DigitalOcean API package) version to v1.13.0[GH-143]
[GH-146]
--do-tagflag[GH-145]