Assume detached state on 404 during ControllerUnpublishVolume #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
assume-detached-on-404
branch
from
d56e8e9
to
ca8b1e4
Compare
nanzhong
requested changes
Nov 27, 2019
test/kubernetes/integration_test.go
Outdated
| pvs, err := client.CoreV1().PersistentVolumes().List(metav1.ListOptions{}) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| }Wait |
There was a problem hiding this comment.
Trailing Wait Snuck in accidentally?
There was a problem hiding this comment.
Ah thanks, good catch -- not sure how that happened.
I wonder if we should extend our CI run to at least build the CI tests. They are on a different build tag, so regular go test won't catch it.
snormore
approved these changes
Nov 27, 2019
nanzhong
approved these changes
Nov 27, 2019
timoreimann
force-pushed
the
assume-detached-on-404
branch
from
93ce15e
to
bbae814
Compare
Previously we would bubble up 404 HTTP response codes during controller unpublish (i.e., volume detachment) events as errors to the invoking external-provisioner, causing the sidecar to go into an infinite retry loop. This change short-circuits the behavior by returning a success message to the caller. One case where we see the problematic behavior occurring is when users detach volumes directly (i.e., outside of Kubernetes).
timoreimann
force-pushed
the
assume-detached-on-404
branch
from
bbae814
to
f869bca
Compare
|
Pushed an update to the change log as well. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would bubble up 404 HTTP response codes during controller unpublish (i.e., volume detachment) events as errors to the invoking external-provisioner, causing the sidecar to go into an infinite retry loop. This change short-circuits the behavior by returning a success message to the caller.
One case where we see the problematic behavior occurring is when users detach volumes directly (i.e., outside of Kubernetes).