Fix button links on elm-pages.com #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I know that a helper was being used for defining this URLs in a safer way however I couldn't actually find the function to understand how it was supposed to work.
✅ Deploy Preview for elm-pages-todos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @georgesboris, sorry I didn't get back to you on this sooner. I prefer to use internal links when possible. Both for the type-safety of the route values, but also for the prefetching of the pages on hover. I went ahead and made a change to support both. Thank you for the PR, I appreciate it! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that a helper was being used for defining this URLs in a safer way however I couldn't actually find the function to understand how it was supposed to work.