Log out a user when user is not active #35143
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
When a user signed in, even if the user get deactivated, as long as the user is still in his session, he can still use commcarehq, which sounds unsafe.
This PR will make sure, after the user is deactivated, the next request he sent, will log him out.
I know it is not user friendly enough, so I created a follow up ticket: https://dimagi.atlassian.net/browse/SAAS-16009. We want to roll this out sooner to solve the issue for CRS.
Technical Summary
Ticket: https://dimagi.atlassian.net/browse/SAAS-15996
I modified the UsersMiddleWare that checks if a user is active during each request
logout function is used in Django documentation: https://docs.djangoproject.com/en/4.2/topics/auth/default/#how-to-log-a-user-out
Safety Assurance
Safety story
This ticket improved safety as we only allow activated user access hq.
Tested locally and on staging.
Automated test coverage
QA Plan
No QA.
Rollback instructions
Labels & Review