ConnectID: Messaging Consent and Key #35212
Conversation
dimagimon
added
the
reindex/migration
pxwxnvermx
changed the title
|
|
||
|
|
||
| class ConnectIDMessagingKey(models.Model): | ||
| domain = models.TextField() |
There was a problem hiding this comment.
I don't think this is necessary since the user_link has a domain field already
There was a problem hiding this comment.
This should have an active boolean as well, so we rotate out keys
There was a problem hiding this comment.
I added the domain here to support the domain deletion test. It was complaining before. I will add the active boolean here as well.
| def connectid_messaging_key(request, domain): | ||
| link = get_object_or_404(ConnectIDUserLink, commcare_user=request.user, domain=request.domain) | ||
| key = generate_aes_key().decode("utf-8") | ||
| messaging_key = ConnectIDMessagingKey.objects.create(connectid_user_link=link, domain=request.domain, key=key) |
There was a problem hiding this comment.
I think this can be get_or_create so we don't generate a new one each time.
| @@ -1685,6 +1687,25 @@ def link_connectid_user(request, domain): | |||
| return HttpResponse() | |||
|
|
|||
|
|
|||
| @csrf_exempt | |||
| @login_or_basic_ex(allow_cc_users=True) | |||
There was a problem hiding this comment.
This needs to allow auth via connectid token, which this decorator can't do. We might need a new decorator that looks up the user via the connectid token (and validates it with connectid), or to just do it in the method.
| @csrf_exempt | ||
| @require_POST | ||
| @login_or_basic_ex(allow_cc_users=True) | ||
| def update_connectid_messaging_consent(request, domain): |
There was a problem hiding this comment.
This will come from the connectid server, not a specific user.
| @@ -3282,6 +3282,14 @@ class ConnectIDUserLink(models.Model): | |||
| connectid_username = models.TextField() | |||
| commcare_user = models.ForeignKey(User, related_name='connectid_user', on_delete=models.CASCADE) | |||
| domain = models.TextField() | |||
| messaging_consent = models.BooleanField(default=False) | |||
There was a problem hiding this comment.
We should have a channel_id as well, since that is how incoming requests will be able to show which channel they go to.
Product Description
No user-facing changes.
Technical Summary
This PR adds functionality to manage consent and keys required for messaging functionality provided by ConnectID.
Ticket
Feature Flag
Safety Assurance
Safety story
Automated test coverage
QA Plan
Migrations
Rollback instructions
Labels & Review