-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cookie_key
is rewriten in ApiBasketMiddleWare.process_response()
#205
Comments
You are right and this can be considered a bug, thanks for reporting. Need to fix this and probably write a test for it. |
@twil But it isn't, probably due to https:/django-oscar/django-oscar-api/blob/master/oscarapi/middleware.py#L163. So yes, the code needs to be changed, and now I think it's even not needed. But I'm not sure so let's ask @specialunderwear I'm not 100% confident here, as this middleware is a bit spooky 😄 |
@maerteijn yep, spooky indeed:) The test doesn't fail because |
For future reference Related branch: https:/django-oscar/django-oscar-api/tree/fix-cookie-key-bug-in-middleware |
This line https:/django-oscar/django-oscar-api/blob/master/oscarapi/middleware.py#L202
overwrites line
196
ifcookies_to_delete
is not emptyThe text was updated successfully, but these errors were encountered: