-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency between product class and product category #340
Comments
Maybe this need a discussion, maybe there's already a consensus on this, but should the API expose slugs or names? My gut feeling is that it should expose names, as I prefer the i18n to happen server side than client side, but this argument does not weight much... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the product class is serialized as a slug while the product category is serialized as a name.
I patched my
ProductSerializer
as:so both are exposed as names. I don't know if it's worth a PR as it may break current uses?
The text was updated successfully, but these errors were encountered: