Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DIP1000: Make 'in' means 'scope' regardless of '-preview=in' #14569

Closed
wants to merge 2 commits into from
Closed

DIP1000: Make 'in' means 'scope' regardless of '-preview=in' #14569

wants to merge 2 commits into from

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Oct 16, 2022 

This somewhat simplifies the code, and decouple DIP1000 behavior from '-preview=in' behavior. The '-preview=in' specific behavior is now limited to the 'ref' / rvalue feature.

Extracted from #14557

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @Geod24!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14569"

thewilsonator
thewilsonator approved these changes Oct 16, 2022
View reviewed changes
Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a changelog entry

@thewilsonator thewilsonator added Needs Changelog A changelog entry needs to be added to /changelog Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org labels Oct 16, 2022
@Geod24
Copy link
Member Author

Geod24 commented Oct 16, 2022

Good point. Depends on #14570 too.

@Geod24 Geod24 mentioned this pull request Oct 16, 2022
Open
@Geod24
Copy link
Member Author

Geod24 commented Oct 16, 2022

Rebased, added changelog, submitted spec change.

@thewilsonator thewilsonator removed the Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org label Oct 16, 2022
@Geod24 Geod24 removed the Needs Changelog A changelog entry needs to be added to /changelog label Oct 17, 2022
@Geod24 Geod24 force-pushed the in-means-scope branch 2 times, most recently from 0014971 to 3dde3c6 Compare October 17, 2022 13:29
@Geod24 Geod24 requested a review from ibuclaw as a code owner October 17, 2022 13:29
@Geod24 Geod24 mentioned this pull request Oct 17, 2022
Merged
@thewilsonator
Copy link
Contributor

any update on this?

@Geod24
Copy link
Member Author

Geod24 commented Oct 26, 2022

Depends on: dlang/tools#453

@thewilsonator
Copy link
Contributor

dependant PR merged.

@Geod24
Copy link
Member Author

Geod24 commented Oct 26, 2022

This breaks too much stuff since DIP1000 is made the default, so I'll have to add inference for it to work out, great...

@Geod24
Copy link
Member Author

Geod24 commented Feb 27, 2023

I think #14929 might just be what I was looking for. Will rebase after it's merged.

@thewilsonator
Copy link
Contributor

Dependant PR merged.

@Geod24
Replace some uses of 'in' with 'const' in tests
18c5fab 
Those tests are not specific to 'in' and assumed 'in' was just 'const'.
@Geod24
DIP1000: Make 'in' means 'scope' regardless of '-preview=in'
386614b 
This somewhat simplifies the code, and decouple DIP1000 behavior from
'-preview=in' behavior. The '-preview=in' specific behavior is now
limited to the 'ref' / rvalue feature.
@thewilsonator
Copy link
Contributor

Need to resync frontend.h

@Geod24
Copy link
Member Author

Geod24 commented Feb 28, 2023

Now that DIP1000 is enabled by default, this can't work anymore, as it breaks in the presence of delegates. So I am afraid I have to close this.

@Geod24 Geod24 closed this Feb 28, 2023
@Geod24 Geod24 deleted the in-means-scope branch February 28, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@ibuclaw ibuclaw Awaiting requested review from ibuclaw ibuclaw is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Geod24 @dlang-bot @thewilsonator