[Video Reader] add caching and retry limit for bad video tolerance #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cached frame in case some video is corrupted and in the previous version it's silently handled by rewinding to nearest "good" frame, this will increase the chance of infinite rewinding if the video is completely corrupted.
So if a corrupted video is read by VideoReader with some
bad
frames(e.g., 200-300 out of 300 frames), retrievingvr[200]
to `vr[299] will return vr[199] instead.If you don't care about duplicate frames in this case, no worries.
If you want to prevent this from happening frequently(not ideal for training), then set the hard limit and catch the error on the fly to detect bad videos: