[CI] Use libomp 13.0.0 to test XGBoost on MacOS #7618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
reviewed
Jan 30, 2022
| @@ -17,10 +17,7 @@ jobs: | |||
| - name: Install osx system dependencies | |||
| if: matrix.os == 'macos-10.15' | |||
| run: | | |||
| # Use libomp 11.1.0: https:/dmlc/xgboost/issues/7039 | |||
| wget https://raw.githubusercontent.com/Homebrew/homebrew-core/679923b4eb48a8dc7ecc1f05d06063cd79b3fc00/Formula/libomp.rb -O $(find $(brew --repository) -name libomp.rb) | |||
| brew install ninja libomp | |||
There was a problem hiding this comment.
If we are using conda, do we still need brew install libomp?
There was a problem hiding this comment.
I don't think we can assume everything is using Conda.
trivialfis
approved these changes
Jan 30, 2022
|
Let me update the docs too. |
|
I want to avoid #7039 (comment) |
|
Closing in favor of #7621 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7039
TODOs
pip install xgboost; this may lead to random crashes. Install XGBoost using Conda for best results."