Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Chinese translate #309

Merged
merged 6 commits into from
Mar 23, 2024
Merged

Add new Chinese translate #309

merged 6 commits into from
Mar 23, 2024

Conversation

Wulian233
Copy link

@Wulian233 Wulian233 commented Mar 23, 2024 •
edited
Loading

Update new add Chinese translation
#306

UlyssesWu
UlyssesWu suggested changes Mar 23, 2024
View reviewed changes
Copy link

@UlyssesWu UlyssesWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just No. We don't need Chinese ellipsis …… or brackets （ ）. As UI text, they don't look compact. Please, check Visual Studio zh-CN style for reference.

@UlyssesWu
Copy link

UlyssesWu commented Mar 23, 2024 •
edited
Loading

Visual Studio:
image

@Wulian233
Copy link
Author

Oh...Sorry, I will correct it

UlyssesWu
UlyssesWu approved these changes Mar 23, 2024
View reviewed changes
Copy link

@UlyssesWu UlyssesWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElektroKill ElektroKill merged commit fd28d71 into dnSpyEx:master Mar 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlyssesWu UlyssesWu UlyssesWu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wulian233 @UlyssesWu @ElektroKill