Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of go-is-domain, ensure it works with non-ICANN names #4

Closed
lidel opened this issue Jun 30, 2021 · 1 comment
Closed

Remove use of go-is-domain, ensure it works with non-ICANN names #4

lidel opened this issue Jun 30, 2021 · 1 comment
Assignees
@martinheidegger
Labels
P0 Critical: Tackled by core team ASAP

Comments

@lidel
Copy link

lidel commented Jun 30, 2021 

	isd "github.com/jbenet/go-is-domain"

See ipfs/kubo#8060 + PRs (ipfs/kubo#8071 & ipfs/go-namesys#13)
@martinheidegger martinheidegger self-assigned this Jun 30, 2021
@lidel lidel added the P0 Critical: Tackled by core team ASAP label Aug 3, 2021
@martinheidegger
Copy link
Contributor

Removed a while back in 8fbbc59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinheidegger martinheidegger

Labels
P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @martinheidegger