-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to only tag images at end of bake #1089
Comments
This has come up today with -
name: Build
uses: docker/bake-action@master
-
name: Build and push
uses: docker/bake-action@master
with:
push: true My issue is I |
An additional issue this can cause is where one target does a file output to a location that is the build context for a separate target. If they're queueing it's currently possible for the files to be written out from the first target to FS, and then they are COPYed into the later target. This is slightly unexpected, I think most users would expect the 'reads' to be based on the FS before the bake starts |
A workaround is to push with different names or even registry, do the testing, and then if testing passes, publish the images under the release names. So if some images don't build, then even though some got pushed, they are test images, and the CI won't move to publish them. |
Currently
bake --push
will tag images in the remote registry as they are completed. This can be an issue if later images in the same high-level build error out.Either the default behaviour could change, or a CLI option could be added that forces tagging to only happen at the end - I don't think pushing new layers would need to be held back.
This example results in a
foo
tag but not thebar
one:The text was updated successfully, but these errors were encountered: