Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: makes git dirty check opt-in #1650

Merged
merged 1 commit into from
Feb 28, 2023
Merged

build: makes git dirty check opt-in #1650

merged 1 commit into from
Feb 28, 2023

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Feb 24, 2023 •
edited
Loading

partially solves #1623

cdupuis
cdupuis approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@cdupuis cdupuis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unfortunate that we have to make this opt-in from a supply chain perspective but it is probably for the greater performance good.

@tonistiigi tonistiigi merged commit 5e685c0 into docker:master Feb 28, 2023
@crazy-max crazy-max deleted the dirty-optin branch February 28, 2023 18:50
@crazy-max crazy-max mentioned this pull request Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdupuis cdupuis cdupuis approved these changes

@tonistiigi tonistiigi tonistiigi approved these changes

@jedevc jedevc Awaiting requested review from jedevc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazy-max @cdupuis @tonistiigi @dvdksn