Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update buildkit, vendor changes #2170

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

laurazard
Copy link
Member

PTAL, they're small changes but I don't really have the context to make sure this is correct.

Related to docker/compose#11283, doing these changes would enable bumping Buildx and Buildkit in Compose to master and solve the OTEL trouble blocking that PR

@thaJeztah
Copy link
Member

Let me also check if moby/buildkit#4496 is good to go

go.mod Outdated Show resolved Hide resolved
@laurazard
Copy link
Member Author

PTAL @crazy-max

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the metrics exporter introduced by moby/buildkit#4460 will be handled in follow-up (cc @jsternberg)

@crazy-max crazy-max merged commit 617f538 into docker:master Dec 19, 2023
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants