Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't filter by services if no filter was set #10145

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Jan 6, 2023

What I did
My assumption regarding docker/roadmap#418 is that services have been created with some profiles enabled. Then as compose ps is executed, without profiles, we get a reduced compose model. As code used to assume no filter == filter by all project services, we actually filter out services launched previously

Related issue
closes docker/roadmap#418

(not mandatory) A picture of a cute animal, if possible in relation to what you did
image

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 73.89% // Head: 72.79% // Decreases project coverage by -1.10% ⚠️

Coverage data is based on head (b326a9d) compared to base (f1313f3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2   #10145      +/-   ##
==========================================
- Coverage   73.89%   72.79%   -1.11%     
==========================================
  Files           2        2              
  Lines         272      272              
==========================================
- Hits          201      198       -3     
- Misses         60       62       +2     
- Partials       11       12       +1     
Impacted Files Coverage Δ
pkg/e2e/framework.go 70.98% <0.00%> (-1.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@nicksieger nicksieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours enabled auto-merge January 9, 2023 10:56
@glours glours merged commit fbbc0de into docker:v2 Jan 9, 2023
@ndeloof ndeloof deleted the ps_filter branch December 20, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker compose ps does not show services from docker-compose.override.yml
3 participants