Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export command #12120

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Add export command #12120

merged 4 commits into from
Oct 2, 2024

Conversation

jarqvi
Copy link
Contributor

@jarqvi jarqvi commented Sep 12, 2024

What I did
I noticed that we have this command in the Docker CLI, but not in Docker Compose. So I thought of adding it to make it useful for others.

@jarqvi jarqvi changed the title Feat/export command feature : export command Sep 12, 2024
@jarqvi jarqvi changed the title feature : export command Add export command Sep 14, 2024
Copy link
Contributor

@ndeloof ndeloof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. Please sign-off your commit

@jarqvi jarqvi force-pushed the feat/export-command branch 2 times, most recently from 1dfa246 to 598a1dc Compare September 17, 2024 16:27
@jarqvi
Copy link
Contributor Author

jarqvi commented Sep 17, 2024

Thank u @ndeloof.
Done.

@jarqvi jarqvi requested a review from ndeloof September 17, 2024 16:27
@ndeloof
Copy link
Contributor

ndeloof commented Sep 17, 2024

not sure how you did, but better rebase on main branch, stash all your commit and amend with --signoff

@jarqvi jarqvi force-pushed the feat/export-command branch 5 times, most recently from 598a1dc to cb0b70a Compare September 17, 2024 18:46
@jarqvi
Copy link
Contributor Author

jarqvi commented Sep 17, 2024

not sure how you did, but better rebase on main branch, stash all your commit and amend with --signoff

Oh sorry, i solved this issue with a messy approach:)

@jarqvi
Copy link
Contributor Author

jarqvi commented Sep 17, 2024

Is this good?
@ndeloof

@ndeloof
Copy link
Contributor

ndeloof commented Sep 17, 2024

Still sign-off line missing in commit message. Maybe amend and add it manually ?

@jarqvi
Copy link
Contributor Author

jarqvi commented Sep 17, 2024

Still sign-off line missing in commit message. Maybe amend and add it manually ?

Done.
@ndeloof

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndeloof ndeloof requested review from a team and jhrotko and removed request for a team September 18, 2024 07:23
@jarqvi
Copy link
Contributor Author

jarqvi commented Sep 18, 2024

Do I have to do anything else?

@ndeloof
Copy link
Contributor

ndeloof commented Sep 18, 2024

@jarqvi just need to fix issues reported by CI :)

@jarqvi
Copy link
Contributor Author

jarqvi commented Sep 18, 2024

@ndeloof done =)

go.mod Outdated Show resolved Hide resolved
@glours
Copy link
Contributor

glours commented Oct 2, 2024

Sorry I rebased the branch to be sure we don't have a conflict, it changed the commit history and broke the DCO 🤦
Can you follow those instructions to fix the sign-off issues?

Signed-off-by: MohammadHasan Akbari <[email protected]>
Signed-off-by: MohammadHasan Akbari <[email protected]>
Signed-off-by: MohammadHasan Akbari <[email protected]>
Signed-off-by: MohammadHasan Akbari <[email protected]>
Signed-off-by: MohammadHasan Akbari <[email protected]>
Signed-off-by: MohammadHasan Akbari <[email protected]>
Signed-off-by: MohammadHasan Akbari <[email protected]>
@jarqvi
Copy link
Contributor Author

jarqvi commented Oct 2, 2024

Sorry I rebased the branch to be sure we don't have a conflict, it changed the commit history and broke the DCO 🤦 Can you follow those instructions to fix the sign-off issues?

Done.
@glours

@glours glours enabled auto-merge (rebase) October 2, 2024 19:12
@glours glours merged commit 60c1311 into docker:main Oct 2, 2024
29 checks passed
@jarqvi jarqvi deleted the feat/export-command branch October 2, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants