add support for raw env_file format #12179
Merged
+67
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
requested review from
glours,
a team and
jhrotko
and removed request for
a team
jhrotko
reviewed
Oct 2, 2024
| command: sh -c "echo $$TEST_VAR" | ||
| env_file: | ||
| - path: .env.raw | ||
| format: raw # parse without interpolation |
There was a problem hiding this comment.
Do you think there can be other formats? I was wondering if it could be a boolean instead raw:true instead
There was a problem hiding this comment.
my goal is to allow reusing docker/cli parser, which this repository can't refer to.
Also, while we don't have another format yet, I could imaging one might want to use java-style properties files, or maybe xml 🧌
jhrotko
approved these changes
Oct 3, 2024
Signed-off-by: Nicolas De Loof <[email protected]>
glours
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add support for env_file
formatwithrawto rely on docker/cli parserrequires
Related issue
fixes #12174
requires docker/cli#5491
requires compose-spec/compose-go#690
(not mandatory) A picture of a cute animal, if possible in relation to what you did
