Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure falsy values in COMPOSE_CONVERT_WINDOWS_PATHS are properly recognized #4294

Merged
merged 1 commit into from
Jan 9, 2017

Conversation

shin-
Copy link

@shin- shin- commented Jan 4, 2017

This was uncovered in #4240 but does not fix the issue - however, it should avoid some of the additional confusion around it.

@shin- shin- added this to the 1.10.0 milestone Jan 4, 2017
@shin- shin- force-pushed the 4240-compose-convert-false branch from 53e31c7 to 534b4ed Compare January 4, 2017 23:45
@shin- shin- merged commit 88294b4 into docker:master Jan 9, 2017
@shin- shin- deleted the 4240-compose-convert-false branch March 23, 2017 23:48
@cmosguy
Copy link

cmosguy commented Mar 30, 2017

Hi @shin- and docker dev folks. So is this wrapped up in the latest docker-compose release? If I understand this fix correctly, Windows users are no longer required to set the COMPOSE_CONVERT_WINDOWS_PATHS variable? Is this still a requirement? Because this is limited in it's documentation and error outputs..

@shin-
Copy link
Author

shin- commented Mar 30, 2017

Newer versions of Docker Machine / Toolbox will set the value for you if it detects it's necessary. Other setups ("Docker For Windows" included) don't need to set this variable. If you're still experiencing problems with host binds on Windows, please open a new issue.

@Dominic-Mathina
Copy link

I still have this issue even after setting the environment variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants