Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bind mounts when in project volumes definition #9514

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

ulyssessouza
Copy link
Contributor

What I did
Fix bind mounts when in project volumes definition

This fixes the type of a volume back to a bind mount

Related issue
Resolves docker/for-mac#6317

pkg/compose/create.go Outdated Show resolved Hide resolved
cmd/compose/compose.go Outdated Show resolved Hide resolved
@ulyssessouza ulyssessouza force-pushed the fix-bindmounts branch 3 times, most recently from 668eadf to 0ba4604 Compare June 1, 2022 21:52
@ulyssessouza ulyssessouza requested a review from ndeloof June 1, 2022 21:53
@ulyssessouza ulyssessouza force-pushed the fix-bindmounts branch 2 times, most recently from 3baaf42 to caa88b2 Compare June 1, 2022 22:22
@ulyssessouza ulyssessouza marked this pull request as ready for review June 1, 2022 22:29
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Device Bind Mount Disconnecting from Container Directory
4 participants