Skip to content

Commit

Permalink
Apply string|int type hints for $writeConcern parameters
Browse files Browse the repository at this point in the history
  • Loading branch information
jmikola committed Apr 19, 2024
1 parent adc0373 commit d8baea8
Showing 1 changed file with 9 additions and 18 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -624,12 +624,9 @@ public static function dataProviderTestWriteConcern(): array
];
}

/**
* @param int|string $writeConcern
* @psalm-param class-string $class
*/
/** @psalm-param class-string $class */
#[DataProvider('dataProviderTestWriteConcern')]
public function testExecuteInsertsRespectsWriteConcern(string $class, $writeConcern): void
public function testExecuteInsertsRespectsWriteConcern(string $class, string|int $writeConcern): void
{
$this->skipTestIfTransactionalFlushEnabled();

Expand All @@ -651,7 +648,7 @@ public function testExecuteInsertsRespectsWriteConcern(string $class, $writeConc

/** @psalm-param class-string $class */
#[DataProvider('dataProviderTestWriteConcern')]
public function testExecuteInsertsOmitsWriteConcernInTransaction(string $class, $writeConcern): void
public function testExecuteInsertsOmitsWriteConcernInTransaction(string $class, string|int $writeConcern): void
{
$this->skipTestIfTransactionalFlushDisabled();

Expand All @@ -671,12 +668,9 @@ public function testExecuteInsertsOmitsWriteConcernInTransaction(string $class,
$this->dm->flush();
}

/**
* @param int|string $writeConcern
* @psalm-param class-string $class
*/
/** @psalm-param class-string $class */
#[DataProvider('dataProviderTestWriteConcern')]
public function testExecuteUpsertsRespectsWriteConcern(string $class, $writeConcern): void
public function testExecuteUpsertsRespectsWriteConcern(string $class, string|int $writeConcern): void
{
$this->skipTestIfTransactionalFlushEnabled();

Expand All @@ -699,7 +693,7 @@ public function testExecuteUpsertsRespectsWriteConcern(string $class, $writeConc

/** @psalm-param class-string $class */
#[DataProvider('dataProviderTestWriteConcern')]
public function testExecuteUpsertsDoesNotUseWriteConcernInTransaction(string $class, $writeConcern): void
public function testExecuteUpsertsDoesNotUseWriteConcernInTransaction(string $class, string|int $writeConcern): void
{
$this->skipTestIfTransactionalFlushDisabled();

Expand All @@ -720,12 +714,9 @@ public function testExecuteUpsertsDoesNotUseWriteConcernInTransaction(string $cl
$this->dm->flush();
}

/**
* @param int|string $writeConcern
* @psalm-param class-string $class
*/
/** @psalm-param class-string $class */
#[DataProvider('dataProviderTestWriteConcern')]
public function testRemoveRespectsWriteConcern(string $class, $writeConcern): void
public function testRemoveRespectsWriteConcern(string $class, string|int $writeConcern): void
{
$this->skipTestIfTransactionalFlushEnabled();

Expand All @@ -750,7 +741,7 @@ public function testRemoveRespectsWriteConcern(string $class, $writeConcern): vo

/** @psalm-param class-string $class */
#[DataProvider('dataProviderTestWriteConcern')]
public function testRemoveDoesNotUseWriteConcernInTransaction(string $class, $writeConcern): void
public function testRemoveDoesNotUseWriteConcernInTransaction(string $class, string|int $writeConcern): void
{
$this->skipTestIfTransactionalFlushDisabled();

Expand Down

0 comments on commit d8baea8

Please sign in to comment.