Search index mapping must be dynamic or specify a field mapping. (#2690)

doctrine · Oct 17, 2024 · da17214 · da17214
1 parent fe0f1ff
commit da17214
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadata.php b/lib/Doctrine/ODM/MongoDB/Mapping/ClassMetadata.php
@@ -1220,9 +1220,15 @@ public function hasIndexes(): bool
  */
  public function addSearchIndex(array $definition, ?string $name = null): void
  {
+ $name ??= self::DEFAULT_SEARCH_INDEX_NAME;
+
+ if (empty($definition['mappings']['dynamic']) && empty($definition['mappings']['fields'])) {
+ throw MappingException::emptySearchIndexDefinition($this->name, $name);
+ }
+
  $this->searchIndexes[] = [
  'definition' => $definition,
- 'name' => $name ?? self::DEFAULT_SEARCH_INDEX_NAME,
+ 'name' => $name,
  ];
  }
 

diff --git a/lib/Doctrine/ODM/MongoDB/Mapping/MappingException.php b/lib/Doctrine/ODM/MongoDB/Mapping/MappingException.php
@@ -291,4 +291,9 @@ public static function nonBackedEnumMapped(string $className, string $fieldName,
  $fieldName,
  ));
  }
+
+ public static function emptySearchIndexDefinition(string $className, string $indexName): self
+ {
+ return new self(sprintf('%s search index "%s" must be dynamic or specify a field mapping', $className, $indexName));
+ }
 }
diff --git a/tests/Doctrine/ODM/MongoDB/Tests/Mapping/ClassMetadataTest.php b/tests/Doctrine/ODM/MongoDB/Tests/Mapping/ClassMetadataTest.php
@@ -971,6 +971,15 @@ public function testDefaultValueForValidationLevel(): void
  $cm = new ClassMetadata('stdClass');
  self::assertEquals(ClassMetadata::SCHEMA_VALIDATION_LEVEL_STRICT, $cm->getValidationLevel());
  }
+
+ public function testEmptySearchIndexDefinition(): void
+ {
+ $cm = new ClassMetadata('stdClass');
+
+ $this->expectException(MappingException::class);
+ $this->expectExceptionMessage('stdClass search index "default" must be dynamic or specify a field mapping');
+ $cm->addSearchIndex(['mappings' => []]);
+ }
 }
 
 /** @template-extends DocumentRepository<self> */