Drop doctrine/common proxies in favor of ProxyManager

[alcaeus]

Q	A
Type	feature
BC Break	yes
Fixed issues	#1813

Summary

This PR replaces the proxy implementation from doctrine/common with ocramius/proxy-manager. Tests are stable, with the exception of two tests that were no longer relevant. BC breaks still need to be documented.

As for a possible BC layer, I'm not sure what this would look like or if we want to spend the time creating one.

Todos:

• Prepare BC layer for 1.3? (separate PR)
• Document BC breaks in UPGRADE document
• Update documentation
• Replace calls to get_class with calls to ClassNameResolver, in which case it should be moved out of the Proxy namespace?

[malarzm]

Indeed the changes are smaller than one could anticipate :)

[alcaeus]

Regarding generation strategies, I'd like to give those some though. Here's what we used to have:

• AUTOGENERATE_ALWAYS: Regardless of whether cached proxy file exists, regenerate and write to disk
• AUTOGENERATE_FILE_NOT_EXISTS: If cached proxy file does not exists, generate and write to disk for future use
• AUTOGENERATE_EVAL: Always use eval to create proxies
• AUTOGENERATE_NEVER: Throw an error if requested proxy was not found in cache

Proxy Manager now only has two strategies that we can currently use:

• FileWriterGeneratorStrategy: writes cached files to disk, essentially replicating AUTOGENERATE_FILE_NOT_EXISTS
• EvaluatingGeneratorStrategy: uses eval to generate proxy classes

We could write our own strategies to replicate the always and never options. always is quite useful for development because you don't need to worry about clearing the cache while never is nice for production to prevent performance regressions. However, I'm not sure if we want to keep them around, WDYT?

[malarzm]

• AUTOGENERATE_ALWAYS - IMO this could be removed, it's good for dev usage where _EVAL will do just fine as well.
• AUTOGENERATE_NEVER - personally I've never used this, IIRC this could be useful for read-only filesystems to ensure Doctrine won't try to write to disk, I think this strategy should stay.

[stof]

AUTOGENERATE_NEVER was added to match the old behavior of doctrine/common when adding more strategies, to allow preserving BC. But FILE_NOT_EXISTS is a better solution anyway.

In case of read-only filesystem, both strategies have the same shortcoming: they both require you to generate all your proxies upfront:

• never always have this requirement (it will require the file without checking for existence, so a non-existent file is a Fatal Error)
• file_not_exists will try to create the missing file, and will fail on read-only filesystems.

So I don't thing the never strategy is actually necessary to support read-only filesystems. If you can generate all proxies upfront, file_not_exists will work just fine for you. and if you cannot, your only choice will be to use eval anyway.

[alcaeus]

Ok, so we're deprecating AUTOGENERATE_NEVER in favour of AUTOGENERATE_FILE_EXISTS and AUTOGENERATE_ALWAYS in favour of AUTOGENERATE_EVAL in 1.3 and dropping them in 2.0. I'll keep the constants around for future compatibility 👍

[malarzm]

Big 👍 beside doc changes

[malarzm]

About that "big 👍" - tests are quite failing 🙈

[alcaeus]

Weird, they were quite stable on my machine. Will have to check that out later.

[Majkl578]

🎉