Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #2544

Merged
merged 13 commits into from
Sep 13, 2023
Merged

Cleanup #2544

merged 13 commits into from
Sep 13, 2023

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Aug 4, 2023 •
edited
Loading

Q A
Type improvement
BC Break no
Fixed issues

Summary

  • Remove @dev from phpbench version
  • Bump minimum version of phpunit to 9.6
  • Move Documents74 namespace to Documents

@alcaeus alcaeus self-assigned this Aug 4, 2023
@alcaeus alcaeus marked this pull request as draft August 4, 2023 15:51
@alcaeus alcaeus marked this pull request as ready for review September 13, 2023 06:55
@alcaeus alcaeus merged commit 9b7ed61 into doctrine:2.6.x Sep 13, 2023
15 checks passed
@alcaeus alcaeus deleted the cleanup branch September 13, 2023 08:54
@malarzm
Copy link
Member

malarzm commented Oct 1, 2023

@alcaeus @franmomu any reason this was merged into 2.6.x instead of 2.5.x? From what I see there'd be nothing wrong with such merge and it'd fix my issues in 2.5.x branch :)

@alcaeus
Copy link
Member Author

alcaeus commented Oct 2, 2023

I wanted to fix the 2.6 build and cut a release, but other things got in the way. I can take another stab at getting 2.6.0 out the door this week, alternatively you can backport the changes to 2.5.

malarzm added a commit that referenced this pull request Oct 2, 2023
@malarzm
Backport cleanup #2544
c689a51
@malarzm malarzm mentioned this pull request Oct 2, 2023
Merged
@malarzm
Copy link
Member

malarzm commented Oct 2, 2023

No hurry, had some time on my hands and did #2553

@malarzm malarzm added the Task label Oct 4, 2023
@malarzm malarzm added this to the 2.6.0 milestone Oct 4, 2023
malarzm added a commit that referenced this pull request Oct 4, 2023
@malarzm
Merge pull request #2553 from doctrine/cleanup-backport
eb7560e 
Backport cleanup #2544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franmomu franmomu franmomu approved these changes

Assignees

@alcaeus alcaeus

Labels
Task
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alcaeus @malarzm @franmomu