Last PHP 8.1 chores #2560
Last PHP 8.1 chores #2560
Conversation
| @@ -14,16 +14,12 @@ | |||
| */ | |||
| class CollWithPHP81Types extends ArrayCollection | |||
| { | |||
| /** | |||
| * @param Collection<TKey, TElement>&ArrayCollection<TKey, TElement> $param | |||
There was a problem hiding this comment.
PHPCS somehow was producing [..]TElement> &ArrayCol[..] (note the space) and I have no willpower to dig into why. Everyone's happy with no PHPDoc ;)
There was a problem hiding this comment.
Maybe prefixing with @psalm- like @psalm-param and @psalm-return would make PHPCS do not fail, anyway I don't know why static analysis is not complaining 🤔
There was a problem hiding this comment.
I think it could be because they got better over time and now they can infer same thing from class' @template-extends and return types? :)
| @@ -14,16 +14,12 @@ | |||
| */ | |||
| class CollWithPHP81Types extends ArrayCollection | |||
| { | |||
| /** | |||
| * @param Collection<TKey, TElement>&ArrayCollection<TKey, TElement> $param | |||
There was a problem hiding this comment.
Maybe prefixing with @psalm- like @psalm-param and @psalm-return would make PHPCS do not fail, anyway I don't know why static analysis is not complaining 🤔
I think these are the last leftovers saying we need to do something once we're rocking PHP 8.1 :)