Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow elements from other namespaces #2607

Open
wants to merge 1 commit into
base: 2.10.x
Choose a base branch
from

Conversation

malarzm
Copy link
Member

@malarzm malarzm commented Jan 16, 2024

This is how we should ideally allow extensions to be combined with ODM's schema. Sadly, this does not work and it seems work on extensions' maintainers is needed anyway :(

Cross referencing doctrine-extensions/DoctrineExtensions#2318

@greg0ire
Copy link
Member

greg0ire commented Jan 16, 2024

Sadly, this does not work and it seems work on extensions' maintainers is needed anyway

I think it's because the extension xsd file is not provided here:

if (! $document->schemaValidate(__DIR__ . '/../../../../../../doctrine-mongo-mapping.xsd')) {
throw MappingException::xmlMappingFileInvalid($filename, $this->formatErrors(libxml_get_errors()));
}

You'd have to let the user provide a schema combining both xsd files as in doctrine/orm#11117 (comment)

@malarzm
Copy link
Member Author

malarzm commented Jan 16, 2024

@greg0ire thanks for all the pointers! I'll prolly join you in doctrine/orm#11123 soon

@alcaeus alcaeus changed the base branch from 2.7.x to 2.10.x September 20, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants