Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure data provider parameters are consistent with test methods signatures #2627

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Ensure data provider parameters are consistent with test methods signatures #2627

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 13 additions & 22 deletions tests/Doctrine/ODM/MongoDB/Tests/Functional/DocumentPersisterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,30 +606,27 @@ public static function dataProviderTestWriteConcern(): array
{
return [
'default' => [
'className' => DocumentPersisterTestDocument::class,
'class' => DocumentPersisterTestDocument::class,
'writeConcern' => 1,
],
'acknowledged' => [
'className' => DocumentPersisterWriteConcernAcknowledged::class,
'class' => DocumentPersisterWriteConcernAcknowledged::class,
'writeConcern' => 1,
],
'unacknowledged' => [
'className' => DocumentPersisterWriteConcernUnacknowledged::class,
'class' => DocumentPersisterWriteConcernUnacknowledged::class,
'writeConcern' => 0,
],
'majority' => [
'className' => DocumentPersisterWriteConcernMajority::class,
'class' => DocumentPersisterWriteConcernMajority::class,
'writeConcern' => 'majority',
],
];
}

/**
* @param int|string $writeConcern
* @psalm-param class-string $class
*/
/** @psalm-param class-string $class */
#[DataProvider('dataProviderTestWriteConcern')]
public function testExecuteInsertsRespectsWriteConcern(string $class, $writeConcern): void
public function testExecuteInsertsRespectsWriteConcern(string $class, string|int $writeConcern): void
{
$this->skipTestIfTransactionalFlushEnabled();

Expand All @@ -651,7 +648,7 @@ public function testExecuteInsertsRespectsWriteConcern(string $class, $writeConc

/** @psalm-param class-string $class */
#[DataProvider('dataProviderTestWriteConcern')]
public function testExecuteInsertsOmitsWriteConcernInTransaction(string $class): void
public function testExecuteInsertsOmitsWriteConcernInTransaction(string $class, string|int $writeConcern): void
{
$this->skipTestIfTransactionalFlushDisabled();

Expand All @@ -671,12 +668,9 @@ public function testExecuteInsertsOmitsWriteConcernInTransaction(string $class):
$this->dm->flush();
}

/**
* @param int|string $writeConcern
* @psalm-param class-string $class
*/
/** @psalm-param class-string $class */
#[DataProvider('dataProviderTestWriteConcern')]
public function testExecuteUpsertsRespectsWriteConcern(string $class, $writeConcern): void
public function testExecuteUpsertsRespectsWriteConcern(string $class, string|int $writeConcern): void
{
$this->skipTestIfTransactionalFlushEnabled();

Expand All @@ -699,7 +693,7 @@ public function testExecuteUpsertsRespectsWriteConcern(string $class, $writeConc

/** @psalm-param class-string $class */
#[DataProvider('dataProviderTestWriteConcern')]
public function testExecuteUpsertsDoesNotUseWriteConcernInTransaction(string $class): void
public function testExecuteUpsertsDoesNotUseWriteConcernInTransaction(string $class, string|int $writeConcern): void
{
$this->skipTestIfTransactionalFlushDisabled();

Expand All @@ -720,12 +714,9 @@ public function testExecuteUpsertsDoesNotUseWriteConcernInTransaction(string $cl
$this->dm->flush();
}

/**
* @param int|string $writeConcern
* @psalm-param class-string $class
*/
/** @psalm-param class-string $class */
#[DataProvider('dataProviderTestWriteConcern')]
public function testRemoveRespectsWriteConcern(string $class, $writeConcern): void
public function testRemoveRespectsWriteConcern(string $class, string|int $writeConcern): void
{
$this->skipTestIfTransactionalFlushEnabled();

Expand All @@ -750,7 +741,7 @@ public function testRemoveRespectsWriteConcern(string $class, $writeConcern): vo

/** @psalm-param class-string $class */
#[DataProvider('dataProviderTestWriteConcern')]
public function testRemoveDoesNotUseWriteConcernInTransaction(string $class): void
public function testRemoveDoesNotUseWriteConcernInTransaction(string $class, string|int $writeConcern): void
{
$this->skipTestIfTransactionalFlushDisabled();

Expand Down
Loading