Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Remove soft-delete-cookbook #2657

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Jun 26, 2024

Q A
Type doc
BC Break no
Fixed issues -

Summary

The repository have been archived: https:/doctrine/mongodb-odm-softdelete

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this count as soft-delete since it's still available in git history? 🤔

@GromNaN
Copy link
Member Author

GromNaN commented Jun 27, 2024

It looks like we can rewrite this cookbook with doctrine extensions: https:/doctrine-extensions/DoctrineExtensions/blob/main/src/SoftDeleteable/Mapping/Event/Adapter/ODM.php

@GromNaN GromNaN added this to the 2.9.0 milestone Jun 27, 2024
@GromNaN GromNaN marked this pull request as draft June 28, 2024 10:06
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a remnant of something older? I can't find a link that is directing to the removed file. 🤔

@GromNaN
Copy link
Member Author

GromNaN commented Jun 30, 2024

Was this a remnant of something older? I can't find a link that is directing to the removed file. 🤔

The sidebar has an automatic listing of all cookbooks:

@GromNaN GromNaN marked this pull request as ready for review July 1, 2024 21:02
@GromNaN GromNaN merged commit 99b4183 into doctrine:2.9.x Jul 1, 2024
17 of 18 checks passed
@GromNaN GromNaN deleted the doc-remove-soft-delete branch July 1, 2024 21:02
alcaeus added a commit that referenced this pull request Sep 6, 2024
* 2.9.x: (24 commits)
  Fix typo in code example (#2670)
  Label PRs about GH actions with "CI" (#2632)
  Review basic mapping (#2668)
  Fix wording (#2667)
  Add native type to private properties and final classes (#2666)
  Review and add tests on `ResolveTargetDocumentListener` (#2660)
  Remove soft-delete-cookbook (#2657)
  doc: Remove wakeup and clone cookbook (#2663)
  Modernize generated code for Hydrators (#2665)
  Add tests for introduction (#2664)
  doc: Review mapping ORM and ODM cookbook (#2658)
  doc: Review cookbook on blending ORM and ODM (#2656)
  doc: Review and test validation cookbook (#2662)
  Update custom mapping example (#2654)
  doc: Review Simple Search Engine Cookbook (#2659)
  doc: Add cookbook about embedding referenced documents using $lookup (#2655)
  doc: Add type to properties (#2652)
  doc: Review custom collections and repository docs (#2653)
  doc: Review Getting Started (#2650)
  Move annotations-reference to attributes-reference (#2651)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants