Ensure compatibility with persistence 4 #2669
Conversation
This is mostly about adding return type declarations. In one instance though, it is more than that: ClassMetadataFactory redeclares $cacheSalt, a protected property inherited from the persistence package. Since it is not possible to widen or narrow the type, and since the redeclaration seems to be about setting a default value, let us set it in the constructor.
greg0ire
force-pushed
the
persistence-4-compat
branch
from
f334334
to
4b5aceb
Compare
| { | ||
| $this->unitOfWork->initializeObject($obj); | ||
| } | ||
|
|
||
| /** | ||
| * Helper method to check whether a lazy loading proxy or persistent collection has been initialized. | ||
| */ | ||
| public function isUninitializedObject(object $obj): bool | ||
| public function isUninitializedObject(mixed $obj): bool |
There was a problem hiding this comment.
How come it's mixed in persistence?
There was a problem hiding this comment.
Can't find the original discussion, but the argument was that if this wasn't mixed, every check would have to be is_object($obj) && $dm->isUninitializedObject($obj). The idea is that anything that isn't an object also isn't an uninitialised object. There was some pushback to changing the interface, and I honestly didn't care enough to force the issue 🤷
There was a problem hiding this comment.
Link to the original discussion: https://doctrine.slack.com/archives/C045LBBNALQ/p1716381659877529
There's still |
This is mostly about adding return type declarations. In one instance though, it is more than that:
ClassMetadataFactoryredeclares$cacheSalt, a protected property inherited from the persistence package. Since it is not possible to widen or narrow the type, and since the redeclaration seems to be about setting a default value, let us set it in the constructor.