Add error handling when misuse of find() with array values #11285
+40
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Feb 21, 2024
Co-authored-by: Alexander M. Turek <[email protected]>
|
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
greg0ire
reviewed
Oct 17, 2024
src/UnitOfWork.php
Outdated
| static function ($value) { | ||
| if ($value instanceof BackedEnum) { | ||
| return $value->value; | ||
| } |
There was a problem hiding this comment.
This looks redundant… isn't it already handled on line 1561?
There was a problem hiding this comment.
The code looks redundant yes, but the check is not ?
There was a problem hiding this comment.
I don't get it… after line 1565, can no longer contain any BackedEnum, right? So why add this check?
There was a problem hiding this comment.
Ok yes got it. I removed this check thank you !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When we (inexpertly) use
$em->find(...)with array values in identifer, it returns a PHP warning..See all details and how to reproduce it in the issue : #11236.
Solution
In this PR
Notes
This PR is a copy of this PR who has been re-targeted to branch
3.1.x