Basic auth #1
Merged
Basic auth #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CircleCI build: https://circleci.com/gh/donbobka/heroku-buildpack-static/4 |
|
Should add specs with valid username and password |
donbobka
force-pushed
the
basic-auth
branch
3 times, most recently
from
8aad096
to
432e625
Compare
donbobka
force-pushed
the
basic-auth
branch
from
432e625
to
0e96a8f
Compare
|
Awesome, thanks so much @donbobka! I'll take a proper look over this later today and get it merged. |
| end | ||
| end | ||
|
|
||
| context "static.json with static.json" do |
There was a problem hiding this comment.
Should this be "static.json with basic_auth key"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @randallagordon. Some features for your PR
auth_basicstatements fromlocationtoserverin nginx configBASIC_AUTH_USERNAMEthen automaticaly enable basic_auth option. Added spec for that case.