Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testable implementation is starting to lag #47

Closed
3 of 4 tasks
domenic opened this issue Oct 7, 2013 · 0 comments
Closed
3 of 4 tasks

Testable implementation is starting to lag #47

domenic opened this issue Oct 7, 2013 · 0 comments

Comments

@domenic
Copy link
Owner

domenic commented Oct 7, 2013

As of 19318d3 it is not up to date with the spec, as it does not handle exceptions in Promise.race per the new behavior. Also, as discovered in #42, internal properties are not inherited, so the way they are currently done is wrong. And the @@create stuff was never quite right.

As #6 is implemented, the delta between how the spec talks about things (with completion values) and how the testable implementation does (by not delving to that level) will grow. So I'll take a pause on updating the testable implementation alongside the spec. Once things settle, especially #6, I will go back and re-do it.

  • @@create vs. constructor semantics are too fake
  • Internal properties should not be inherited; currently scheme is too simple.
  • Completion values are not handled
  • Make sure all the tests still pass with the updated implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant