Fix path to maps in AdobeFontMetrics.php #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`dirname(__FILE__)` gives you `php-font-lib/src/Fontlib` `dirname(__FILE__) . '/../'` gives you `php-font-lib/src/` We need one more level up, to hit /maps. P.S. We can also use `__DIR__ . '/../../'` OR `dirname(__DIR__) . '/../'`
bsweeney
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently get
Fatal error: Uncaught Exception: Unknown encodingwhenever passing an encoding tosaveAdobeFontMetrics. This is because we aren't correctly pointing to themaps/directory.dirname(__FILE__)gives youphp-font-lib/src/Fontlibdirname(__FILE__) . '/../'gives youphp-font-lib/src/We need one more level up, to hit /maps.
P.S. We can also use
__DIR__ . '/../../'ORdirname(__DIR__) . '/../'