-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup job removes not expired tokens #1688
Comments
Hello @jensljungblad I don't think there is an issue with this, could you provide a failing test that proves your point? In so we have:
And these 2 statements are equivalent. (I only have a doubt about |
This is a follow-up to #1612 which was closed by #1625.
The PR fixed half of the problem. The issue is that the rake task
doorkeeper:db:cleanup:expired_tokens
will still delete tokens which haven't yet expired. The reason is that theexpires_in
column is not considered.Compare the logic in
With
The text was updated successfully, but these errors were encountered: