Fix token introspection invalid request reason #1715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbulaj
approved these changes
Jul 12, 2024
ransombriggs
force-pushed
the
fix-error-message-on-introspection
branch
from
376d5ac
to
d86fc47
Compare
|
I rebased from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I was validating the client authentication in the token introspection endpoint and got a "The request is missing a required parameter, includes an unsupported parameter value, or is otherwise malformed." error which was kind of confusing and so I took a look at the code and this appears to be not intentional. The
invalid_request_reasonis a private method so when thetry(:invalid_request_reason)runs it returnsniland so it falls back to the default. I went with a quick fix but making theattr_readerpublic so that the error_description is set properly.