Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 3.3 to GitHub Actions testing matrix #1723

Merged

Conversation

ThisIsMissEm
Copy link
Contributor

Summary

Ruby 3.3.4 is the current latest stable version of Ruby, however, we are currently not testing it in GitHub Actions (we were only going up to ruby 3.2)

This adds support for 3.3 to the testing matrix.

I do note that according to the Gemspec, we support >= 2.7, so we should probably also include Ruby 2.7 in the testing matrix at least.

Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I do note that according to the Gemspec, we support >= 2.7, so we should probably also include Ruby 2.7 in the testing matrix at least.

While we're trying to support older Rubies as well (I mean we're trying to allow legacy projects to still use newer versions of the gem) I don't think there is much sense to add EOL ruby to the test matrix. Inconvenient, yes, but that's how I personally see it.

@nbulaj nbulaj merged commit ef629da into doorkeeper-gem:main Jul 30, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants