Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unless computed columns are included, serialization does not work in Mono #28

Open
andreasdamm opened this issue Mar 18, 2014 · 3 comments

Comments

@andreasdamm
Copy link

ProtoDataColumnFactory.GetColumns ignores schema rows when Expression is not DBNull unless ProtoDataWriterOptions has IncludeComputedColumns turned on. In Mono DataTableReader.GetSchemaTable always has an Expression column with a value of string.Empty. Need to check for empty string in addition to DBNull.

rdingwall added a commit that referenced this issue Jun 16, 2014
…ull expression, rather than System.DBNull.
@rdingwall
Copy link
Collaborator

Hi @andreasdamm can you check commit c89b917 and let me know if that fix works?

@andreasdamm
Copy link
Author

Thanks for the fix. It might take a while though, before I can test it, sorry.

On 6/16/2014 5:05 PM, Richard Dingwall wrote:

Hi @andreasdammhttps:/andreasdamm can you check commit c89b917c89b917 and let me know if that fix works?


Reply to this email directly or view it on GitHubhttps://issues/28#issuecomment-46249194.

Disclaimer: This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this email. Please notify the sender immediately by email if you have received this email by mistake and delete this email from your system.

Our company accepts no liability for the content of this email, or for the consequences of any actions taken on the basis of the information provided. Any views or opinions presented in this email are solely those of the author and do not necessarily represent those of the company. Finally, the recipient should check this email and any attachments for the presence of viruses. The company accepts no liability for any damage caused by any virus transmitted by this email.

InsightSoftware.com is a Trading Name of 'InsightSoftware.com Limited',Registered in England No. 2860790 at 53-55 Uxbridge Road, Ealing, London, W5 5SA, United Kingdom, VAT Number: GB 766 8160 95

@parndt
Copy link

parndt commented Dec 10, 2014

@andreasdamm any luck?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants