Get full parsable version part in .NET SDK Validator #2646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately there was a bug introduced in #2645 that I missed which this PR will fix. Essentially if you use
--runtimes monoaotllvm
or--runtimes wasm
, it would actually returnnew Version(9, 0, 0)
because it defers toCoreRuntime.TryGetVersion()
to get the version. The code that parsed the output ofdotnet --list-sdks
was only looking at the major and minor versions, and so the comparison ofnew Version(9, 0, 0) <= new Version(9, 0)
was returning false. With this change we will read the full version string including the feature band/patch version.In the dotnet/runtime performance tests we don't use
--runtimes wasm
but we do use--runtimes monoaotllvm
to run the Mono AOT benchmarks, so this will fix that one. I'm doing some more testing locally but wanted to get the PR out now so it can get some reviews and get it merged quickly.