Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xamarin.Android.Build.Tasks] Fix Removal of Non Duplicate elements #856

Merged
merged 1 commit into from
Sep 14, 2017

Commits on Sep 14, 2017

  1. [Xamarin.Android.Build.Tasks] Fix Removal of Non Duplicate elements

    Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=59473
    
    Commit d079a42 went a bit too far when removing duplicates.
    It removed ANY duplicate entry that appeared anywhere in the
    document. What we really wanted to remove full duplicates that
    exist at the same level as the current element in the document.
    For example
    
    ```xml
    	<foo>
    		<bar name="bar1">
    		  <bar2 />
    		</bar>
                    <bar name="bar2">
                      <bar2 />
                    </bar>
    		<dupe/>
    		<dupe/>
    	</foo>
    ```
    
    `bar2` should NOT be removed but one of the `dupe` values should.
    So this commit reworks the RemoveDuplicates code to handle the
    correct logic. It also adds a unit test for this exact senario.
    dellis1972 committed Sep 14, 2017
    Configuration menu
    Copy the full SHA
    c511570 View commit details
    Browse the repository at this point in the history