Update tools.ps1/tools.sh to avoid hiding errored exit codes (#11869)

Fixes #11589

eng/common/tools.ps1

@@ -815,7 +815,8 @@ function MSBuild-Core() {
  Write-Host "See log: $buildLog" -ForegroundColor DarkGray
  }
 
- if ($ci) {
+ # When running on Azure Pipelines, override the returned exit code to avoid double logging.
+ if ($ci -and $env:SYSTEM_TEAMPROJECT -ne $null) {
  Write-PipelineSetResult -Result "Failed" -Message "msbuild execution failed."
  # Exiting with an exit code causes the azure pipelines task to log yet another "noise" error
  # The above Write-PipelineSetResult will cause the task to be marked as failure without adding yet another error

eng/common/tools.sh

@@ -472,7 +472,9 @@ function MSBuild-Core {
  # We should not Write-PipelineTaskError here because that message shows up in the build summary
  # The build already logged an error, that's the reason it failed. Producing an error here only adds noise.
  echo "Build failed with exit code $exit_code. Check errors above."
- if [[ "$ci" == "true" ]]; then
+
+ # When running on Azure Pipelines, override the returned exit code to avoid double logging.
+ if [[ "$ci" == "true" && -n ${SYSTEM_TEAMPROJECT:-} ]]; then
  Write-PipelineSetResult -result "Failed" -message "msbuild execution failed."
  # Exiting with an exit code causes the azure pipelines task to log yet another "noise" error
  # The above Write-PipelineSetResult will cause the task to be marked as failure without adding yet another error