[H/3] Fix code passed into QuicConnection.CloseAsync and QuicStream.Abort #55282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the code passed into
QuicConnection.CloseAsync
andQuicStream.Abort
which was by default -1. Quic supports only error codes up to 62 bits non-negative integer values: https://www.rfc-editor.org/rfc/rfc9000.html#integer-encoding.Also added test which crashes the process (if running with DEBUG build of MsQuic) before this change and runs to completion afterwards.
Let me know if you want me to shuffle the code around, I'm not much familiar with the structure of your code base.
cc @amcasey
Fixes #55196
Also this will be followed up in S.N.Quic with some checks (dotnet/runtime#101385).