Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netstandard tests aren't currently running #20065

Closed
weshaggard opened this issue Jan 31, 2017 · 1 comment
Closed

netstandard tests aren't currently running #20065

weshaggard opened this issue Jan 31, 2017 · 1 comment
Labels
Milestone

Comments

@weshaggard
Copy link
Member

Any test projects that have both a netcoreapp and netstandard build configuration is only ever running the tests for netcoreapp. So any tests that are conditioned for netstandard only are not currently being ran. System.Runtime (https:/dotnet/corefx/blob/master/src/System.Runtime/tests/System.Runtime.Tests.csproj) is an example of such a project.

We need to decide whether or not we should run all compatible configurations for a given vertical or only run the most specific configuration for the vertical and make sure it correctly aggregates all the tests.

One drawback to doing only the one configuration is we want have any tests built against netstandard and running in the context of that vertical.

cc @ericstj @joperezr @tarekgh @mellinoe

@wtgodbe
Copy link
Member

wtgodbe commented Dec 28, 2018

Closing as dup of https:/dotnet/corefx/issues/30729

@wtgodbe wtgodbe closed this as completed Dec 28, 2018
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 3.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants