Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote netcoreapp tests to netstandard as possible #24062

Closed
danmoseley opened this issue Nov 6, 2017 · 3 comments
Closed

Promote netcoreapp tests to netstandard as possible #24062

danmoseley opened this issue Nov 6, 2017 · 3 comments
Labels
area-Meta test-enhancement Improvements of test source code
Milestone

Comments

@danmoseley
Copy link
Member

Tests that run only against .NET Standard surface area should run in the netstandard configuration so they can be reused against other netstandard implementations. It is likely that we currently have some tests running in the netcoreapp configuration that could be run in netstandard. We should do a pass through in order to beef up our netstandard coverage.

@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 26, 2018

The following test projects should be promoted to netstandard as the corresponding source assembly builds against netstandard and is not a turd assembly (PNSE assembly):

@ViktorHofer ViktorHofer self-assigned this Aug 26, 2018
@ViktorHofer ViktorHofer removed their assignment Dec 6, 2018
@stephentoub
Copy link
Member

@ViktorHofer, is this issue still relevant?

@ViktorHofer
Copy link
Member

No this isn't necessary anymore. Thanks.

@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 5.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta test-enhancement Improvements of test source code
Projects
None yet
Development

No branches or pull requests

4 participants