Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Expose the ExternalAttributes field in ZipArchive #18565

Merged
merged 3 commits into from
Apr 19, 2017
Merged

Expose the ExternalAttributes field in ZipArchive #18565

merged 3 commits into from
Apr 19, 2017

Commits on Apr 18, 2017

  1. Expose the ExternalAttributes field in ZipArchive

    The ExternalFileAttributes field of a ZipArchiveEntry is currently hidden within the implementation and not accessible. This has been fine in the Windows world since it's not used but it is used by Unix's zip/unzip programs to store file permissions of an entry. As it currently stands, there is no way to carry Unix RWX permissions within a zip, so at unzip time the unzipper has to guess at permissions and manually chmod the entries. This PR simply exposes the raw field so that it may be used in any circumstance that requires access to the field. Tests are added to ensure that this field is set, read, and roundtrips properly with zips created from other common programs which use the field.
    Ian Hays committed Apr 18, 2017
    Configuration menu
    Copy the full SHA
    efd10d9 View commit details
    Browse the repository at this point in the history
  2. Add ZipArchive test for full roundtrip ExternAttr

    Ian Hays committed Apr 18, 2017
    Configuration menu
    Copy the full SHA
    9b67943 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2017

  1. Fix casing for Compression TestData package import

    Ian Hays committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    39e44d6 View commit details
    Browse the repository at this point in the history